Skip to content

Conversation

@EvanBacon
Copy link
Contributor

Why

  • eas metadata:pull fails in pillar valley because it's published and doesn't have an editable version. This is the state my app is usually in.
  • This causes a bunch of errors, when the errors are skipped, then it simply just clears the config.
  Store configuration download encountered 6 errors.                                                                                                                   
                                                                                                                                                                       
  Could not resolve a live or editable app version                                                                                                                     
                                                                                                                                                                       
  Could not resolve the editable app info to update                                                                                                                    
                                                                                                                                                                       
  App version information is not prepared, can't update age rating                                                                                                     
                                                                                                                                                                       
  App version not initialized, can't download store review details                                                                                                     
                                                                                                                                                                       
  App version not initialized, can't download version                                                                                                                  
                                                                                                                                                                       
  App info not initialized, can't download info                                                                                                                        

How

  • Updated Apple metadata tasks to skip operations when app version or info is not available.
  • instead of throwing errors. This improves support for cases where the app or version has not been set up yet, particularly for metadata:pull. Tests have been updated to reflect the new behavior.

Test Plan

  • Running in pillar valley works as expected, it pulls the latest possible metadata to the config.

Updated Apple metadata tasks to skip operations when app version or info is not available, instead of throwing errors. This improves support for cases where the app or version has not been set up yet, particularly for metadata:pull. Tests have been updated to reflect the new behavior.
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/metadata/** @byCedric

Generated by CodeMention

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions
Copy link

Size Change: -1.41 kB (0%)

Total Size: 53.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.3 MB -1.41 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.61%. Comparing base (3a7182b) to head (0ffede9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/eas-cli/src/metadata/apple/tasks/app-version.ts 62.50% 3 Missing ⚠️
...kages/eas-cli/src/metadata/apple/tasks/app-info.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
- Coverage   49.61%   49.61%   -0.00%     
==========================================
  Files         671      671              
  Lines       27972    27979       +7     
  Branches     5780     5788       +8     
==========================================
+ Hits        13876    13878       +2     
- Misses      12906    12911       +5     
  Partials     1190     1190              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanBacon EvanBacon requested a review from byCedric January 10, 2026 20:40
@EvanBacon EvanBacon merged commit 460f98d into main Jan 10, 2026
11 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metadata/pull-live-version branch January 10, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants