Conversation
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +9.29 kB (+0.02%) Total Size: 57.5 MB
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3376 +/- ##
==========================================
- Coverage 52.54% 52.27% -0.27%
==========================================
Files 806 807 +1
Lines 33621 33885 +264
Branches 6986 7034 +48
==========================================
+ Hits 17664 17710 +46
- Misses 14571 14773 +202
- Partials 1386 1402 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
packages/eas-cli/src/commands/go.ts
Outdated
| analytics, | ||
| vcsClient, | ||
| easJsonCliConfig: { | ||
| promptToConfigurePushNotifications: false, |
There was a problem hiding this comment.
Should we prompt for push notifications setup? Do we want this Expo Go to have notifications? Maybe that's not the goal here?
There was a problem hiding this comment.
Ideally we would preserve all behavior but if there's any issue with push notifications we are fine dropping them I think
There was a problem hiding this comment.
I am not sure. We are probably fine with notifications missing if that would block us otherwise
There was a problem hiding this comment.
i'm fine with skipping notifications. although if we already added support for the notification extension when repacking, then maybe it's worth prompting for this
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
3 participants
Why
We want to give users an option to create custom Expo Go builds in CLI.
How
Using a mix of existing commands.
Note: the release build of Expo Go for SDK 55 is hardcoded right now, together with version numbers.
Test Plan
Ran locally several times. Expected behavior: user is authenticated with their apple developer account, repack & TestFlight jobs run, after processing Apple sends a TestFlight invite email.