Conversation
…ailure Signed-off-by: Ash Wu <hsatac@gmail.com>
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
Feb 25, 2026
hSATAC
deleted the
ash/eng-19032-report-workflowtestcaseresult-in-reuse_device-true-route-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
parseMaestroResults and the duplicate name check were outside the try-catch block. If an unexpected error escaped from parsing, the step would be marked as failed, potentially affecting the user's build. This step should be best-effort — errors should never propagate.
How
Moved the try boundary up to cover parseMaestroResults and the duplicate check, so the entire step logic (besides early-exit skips) is wrapped in a single try-catch.
Test Plan