Skip to content

[build-tools] Handle ASC SDK version issue (90725)#3464

Merged
sjchmiela merged 6 commits intomainfrom
stanley/asc-90725-sdk-version-issue
Mar 17, 2026
Merged

[build-tools] Handle ASC SDK version issue (90725)#3464
sjchmiela merged 6 commits intomainfrom
stanley/asc-90725-sdk-version-issue

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented Mar 5, 2026

Why

UNKNOWN submit failures include App Store Connect SDK compatibility error 90725.

This should be surfaced as actionable EAS guidance (rebuild with newer iOS SDK/Xcode image) instead of generic unknown.

How

  • add 90725 detection in upload_to_asc failed-state handling
  • throw EAS_UPLOAD_TO_ASC_SDK_VERSION_ISSUE with EAS-specific remediation
  • include docs URL to iOS build image/Xcode configuration docs
  • add unit tests for isSdkVersionIssueError

Examples

Test Plan

  • yarn --cwd packages/build-tools jest-unit src/steps/functions/__tests__/uploadToAsc.test.ts
  • yarn --cwd packages/build-tools typecheck
  • yarn fmt

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.62%. Comparing base (99b8d67) to head (f28c441).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ges/build-tools/src/steps/functions/uploadToAsc.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   53.62%   53.62%   -0.00%     
==========================================
  Files         815      815              
  Lines       34622    34626       +4     
  Branches     7192     7194       +2     
==========================================
+ Hits        18562    18564       +2     
- Misses      15979    15981       +2     
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela force-pushed the stanley/asc-90725-sdk-version-issue branch from 1917875 to 1acd7fe Compare March 13, 2026 14:46
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Mar 16, 2026
@sjchmiela sjchmiela requested a review from hSATAC March 16, 2026 15:47
@sjchmiela sjchmiela marked this pull request as ready for review March 16, 2026 15:48
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/asc-90725-sdk-version-issue branch from 2a96c42 to 461f11a Compare March 17, 2026 15:25
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela merged commit bc8e60d into main Mar 17, 2026
7 checks passed
@sjchmiela sjchmiela deleted the stanley/asc-90725-sdk-version-issue branch March 17, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants