[eas-cli] remove image override in eas build:resign#3661
Conversation
Signed-off-by: Ash Wu <hsatac@gmail.com>
Signed-off-by: Ash Wu <hsatac@gmail.com>
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention |
There was a problem hiding this comment.
Pull request overview
Removes an outdated builderEnvironment.image: 'default' override from the eas build:resign retry payload so the server can preserve (or default) the build image based on the parent build, avoiding failures for Workflow-triggered parent builds.
Changes:
- Remove hardcoded
builderEnvironment: { image: 'default' }from iOS resignjobOverridespayload. - Add a changelog entry documenting the bug fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eas-cli/src/commands/build/resign.ts | Stops overriding the builder image during iOS build resign retry so the parent build image can be used. |
| CHANGELOG.md | Records the bug fix in the main changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
=======================================
Coverage ? 55.87%
=======================================
Files ? 868
Lines ? 37544
Branches ? 7835
=======================================
Hits ? 20973
Misses ? 16473
Partials ? 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why
eas build:resigncurrently passes a hardcodedbuilderEnvironment: { image: 'default' }override to the server when retrying an iOS build. It was added as a placeholder when the command was first introduced (#1575, 2022).This override is now unnecessary at best, broken at worst:
eas buildparents, the server falls back to a default image when one isn't specified, so the override is redundant.'default'as a valid image alias. The hardcoded override silently replaces the parent build's resolved concrete image (e.g.macos-sequoia-15.6-xcode-26.2) with'default', causingeas build:resignto fail with anunknown imageerror.The correct behavior in both cases is "resign with the parent's image" — which is exactly what happens when this override is absent.
How
Drop the
builderEnvironmentfield from the resignjobOverridespayload. The server-side retry path then picks up the parent build's image automatically:eas buildparents: same behavior as before (server falls back to a default on its side).unknown image.Android resign is explicitly unsupported (the command throws on Android), so this affects iOS only.
Test Plan