Skip to content

[eas-cli] remove image override in eas build:resign#3661

Merged
hSATAC merged 2 commits intomainfrom
ash/eng-20894-remove-image-override-in-eas-buildresign
Apr 30, 2026
Merged

[eas-cli] remove image override in eas build:resign#3661
hSATAC merged 2 commits intomainfrom
ash/eng-20894-remove-image-override-in-eas-buildresign

Conversation

@hSATAC
Copy link
Copy Markdown
Contributor

@hSATAC hSATAC commented Apr 30, 2026

Why

eas build:resign currently passes a hardcoded builderEnvironment: { image: 'default' } override to the server when retrying an iOS build. It was added as a placeholder when the command was first introduced (#1575, 2022).

This override is now unnecessary at best, broken at worst:

  • For regular eas build parents, the server falls back to a default image when one isn't specified, so the override is redundant.
  • For EAS Workflow-triggered parents, the build infrastructure no longer recognizes 'default' as a valid image alias. The hardcoded override silently replaces the parent build's resolved concrete image (e.g. macos-sequoia-15.6-xcode-26.2) with 'default', causing eas build:resign to fail with an unknown image error.

The correct behavior in both cases is "resign with the parent's image" — which is exactly what happens when this override is absent.

How

Drop the builderEnvironment field from the resign jobOverrides payload. The server-side retry path then picks up the parent build's image automatically:

  • Regular eas build parents: same behavior as before (server falls back to a default on its side).
  • EAS Workflow-triggered parents: the parent's concrete image flows through; resign no longer fails with unknown image.

Android resign is explicitly unsupported (the command throws on Android), so this affects iOS only.

Test Plan

  • Automation tests

Signed-off-by: Ash Wu <hsatac@gmail.com>
@linear
Copy link
Copy Markdown

linear Bot commented Apr 30, 2026

Signed-off-by: Ash Wu <hsatac@gmail.com>
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@hSATAC hSATAC requested review from Copilot and sjchmiela April 30, 2026 14:50
@hSATAC hSATAC marked this pull request as ready for review April 30, 2026 14:51
@hSATAC hSATAC requested a review from douglowder April 30, 2026 14:51
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/build/** @sjchmiela

Generated by CodeMention

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an outdated builderEnvironment.image: 'default' override from the eas build:resign retry payload so the server can preserve (or default) the build image based on the parent build, avoiding failures for Workflow-triggered parent builds.

Changes:

  • Remove hardcoded builderEnvironment: { image: 'default' } from iOS resign jobOverrides payload.
  • Add a changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/eas-cli/src/commands/build/resign.ts Stops overriding the builder image during iOS build resign retry so the parent build image can be used.
CHANGELOG.md Records the bug fix in the main changelog.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@02ba588). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3661   +/-   ##
=======================================
  Coverage        ?   55.87%           
=======================================
  Files           ?      868           
  Lines           ?    37544           
  Branches        ?     7835           
=======================================
  Hits            ?    20973           
  Misses          ?    16473           
  Partials        ?       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hSATAC hSATAC merged commit 91c9331 into main Apr 30, 2026
15 checks passed
@hSATAC hSATAC deleted the ash/eng-20894-remove-image-override-in-eas-buildresign branch April 30, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants