[eas-cli] Add lockfile existence preflight check for eas build#3665
Merged
AbbanMustafa merged 1 commit intomainfrom May 4, 2026
Merged
[eas-cli] Add lockfile existence preflight check for eas build#3665AbbanMustafa merged 1 commit intomainfrom
AbbanMustafa merged 1 commit intomainfrom
Conversation
|
Subscribed to pull request
Generated by CodeMention |
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3665 +/- ##
==========================================
+ Coverage 55.87% 55.88% +0.02%
==========================================
Files 868 869 +1
Lines 37545 37568 +23
Branches 7835 7841 +6
==========================================
+ Hits 20973 20992 +19
- Misses 16474 16478 +4
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjchmiela
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
~3k builds fail weekly during
install_dependenciesbecause of lockfile issues. The most basic failure mode, a missing lockfile, can be caught before the build is even queued, giving instant feedback instead of waiting for a remote build to fail.This is the first of several small PRs breaking up #3434
How
Added a single preflight check in
prepareAndStartBuildAsync()that verifies at least one known lockfile (package-lock.json,yarn.lock,pnpm-lock.yaml,bun.lockb,bun.lock) exists in the project directory or workspace root (monorepo support viaresolveWorkspaceRoot).metroConfigValidated/sdkVersionCheckedpattern.localBuildMode), since local builds install deps locally.EAS_BUILD_SKIP_LOCKFILE_CHECK=1env var.Test Plan
Unit tests covering all lockfile types, missing lockfile error, and monorepo scenarios
Verified cli output