Conversation
|
Subscribed to pull request
Generated by CodeMention |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3685 +/- ##
==========================================
+ Coverage 56.56% 56.59% +0.03%
==========================================
Files 888 888
Lines 38468 38490 +22
Branches 8022 8025 +3
==========================================
+ Hits 21756 21778 +22
Misses 16614 16614
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mackenco
approved these changes
May 8, 2026
99e75e7 to
e050177
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In our Convex docs (https://docs.expo.dev/guides/using-convex/#save-the-convex-url-as-an-eas-environment-variable), we tell people to set an ENV var with EAS to use in their deployments. With our Convex integration, we can automate this step and make the setup UX even smoother.
Fixes ENG-21068
How
I added a step to the convex:connect command to set the
EXPO_PUBLIC_CONVEX_URLEAS env var. If it already exists, we prompt the user to prevent accidental rewrites.Test Plan
yarn buildand using the localeasdalias, runEXPO_STAGING=true easd integrations:convex:connectYou should see the new output talking about the env var, and the env var should also be visible in the env var dashboard page: