[eas-build-job] Preserve workflow job outputs#3704
Merged
Conversation
|
Subscribed to pull request
Generated by CodeMention |
b7a03f9 to
096ec49
Compare
096ec49 to
e98d716
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3704 +/- ##
==========================================
+ Coverage 56.59% 56.59% +0.01%
==========================================
Files 888 888
Lines 38496 38498 +2
Branches 8026 8026
==========================================
+ Hits 21784 21786 +2
Misses 16614 16614
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
szdziedzic
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a shared
JobOutputstype/schema and preserves declared workflow job outputs in Android, iOS, and generic job definitions.Before this change,
outputswas stripped from several build job shapes during Joi validation, including normal build jobs and custom builds that usecustomBuildConfig.path. That meant downstream worker code could not uploadjobs.<name>.outputsfor workflowtype: buildjobs.Changes
JobOutputs,JobOutputsSchema, andJobOutputsSchemaZdefinitions incommon.ts.outputsdirectly on the Android and iOS top-level job schemas.CustomBuildConfigSchema, so that schema only controls custom config vs inline step shape.Validation
packages/eas-build-job:yarn test android.test.ts ios.test.ts generic.test.tspackages/eas-build-job:yarn buildyarn oxfmt --check ...