Skip to content

[eas-build-job] Preserve workflow job outputs#3704

Merged
sjchmiela merged 1 commit into
mainfrom
stanley/job-outputs-schema
May 11, 2026
Merged

[eas-build-job] Preserve workflow job outputs#3704
sjchmiela merged 1 commit into
mainfrom
stanley/job-outputs-schema

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented May 11, 2026

Summary

This adds a shared JobOutputs type/schema and preserves declared workflow job outputs in Android, iOS, and generic job definitions.

Before this change, outputs was stripped from several build job shapes during Joi validation, including normal build jobs and custom builds that use customBuildConfig.path. That meant downstream worker code could not upload jobs.<name>.outputs for workflow type: build jobs.

Changes

  • Add shared JobOutputs, JobOutputsSchema, and JobOutputsSchemaZ definitions in common.ts.
  • Use the shared output type/schema from Android, iOS, and Generic job definitions.
  • Validate outputs directly on the Android and iOS top-level job schemas.
  • Remove output handling from CustomBuildConfigSchema, so that schema only controls custom config vs inline step shape.
  • Add Android and iOS schema coverage for normal build jobs, config-path custom jobs, and iOS resign jobs.

Validation

  • packages/eas-build-job: yarn test android.test.ts ios.test.ts generic.test.ts
  • packages/eas-build-job: yarn build
  • yarn oxfmt --check ...

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/job-outputs-schema branch from b7a03f9 to 096ec49 Compare May 11, 2026 10:53
@sjchmiela sjchmiela force-pushed the stanley/job-outputs-schema branch from 096ec49 to e98d716 Compare May 11, 2026 10:56
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.59%. Comparing base (f856d40) to head (e98d716).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
+ Coverage   56.59%   56.59%   +0.01%     
==========================================
  Files         888      888              
  Lines       38496    38498       +2     
  Branches     8026     8026              
==========================================
+ Hits        21784    21786       +2     
  Misses      16614    16614              
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label May 11, 2026
@sjchmiela sjchmiela requested a review from szdziedzic May 11, 2026 11:50
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela merged commit 0d5ef2e into main May 11, 2026
10 of 11 checks passed
@sjchmiela sjchmiela deleted the stanley/job-outputs-schema branch May 11, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants