[eas-cli] Add expoPackageVersion to build metadata#3725
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3725 +/- ##
==========================================
+ Coverage 56.36% 56.41% +0.06%
==========================================
Files 897 902 +5
Lines 38773 38857 +84
Branches 8059 8069 +10
==========================================
+ Hits 21849 21919 +70
- Misses 16818 16831 +13
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
expoPackageVersion to build metadata
d781da6 to
cdbc01c
Compare
|
Subscribed to pull request
Generated by CodeMention |
AbbanMustafa
approved these changes
May 13, 2026
szdziedzic
approved these changes
May 14, 2026
cdbc01c to
2c9952f
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Persist the installed
expopackage version separately fromsdkVersionso server-side log uploads can reproduce the legacyexpo_package_versionDatadog tag without conflating it with SDK version.How
expoPackageVersionto build metadata schema/types.getExpoPackageVersionAsync(...)behavior into shared@expo/eas-build-job#getInstalledExpoPackageVersionAsync(...):node --print require.resolve('expo/package.json'),fs.readJson, semver validation, and the sameEAS_BUILD_EXPO_PACKAGE_VERSION_*UserErrors.collectMetadataAsync(...)now resolvesexpoPackageVersioninline withasyncResult(getInstalledExpoPackageVersionAsync(...)).value, so build creation and the existing internalupdateBuildMetadatapath send it alongside the rest of the build metadata.expo_package_versionfrom build metadata; the worker no longer resolves or mutates this field.Test Plan
CI should pass.