Skip to content

[eas-cli] Add expoPackageVersion to build metadata#3725

Merged
sjchmiela merged 14 commits into
mainfrom
stanley/expo-package-version-metadata-20260513
May 15, 2026
Merged

[eas-cli] Add expoPackageVersion to build metadata#3725
sjchmiela merged 14 commits into
mainfrom
stanley/expo-package-version-metadata-20260513

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented May 13, 2026

Why

Persist the installed expo package version separately from sdkVersion so server-side log uploads can reproduce the legacy expo_package_version Datadog tag without conflating it with SDK version.

How

  • Added expoPackageVersion to build metadata schema/types.
  • Moved the existing worker getExpoPackageVersionAsync(...) behavior into shared @expo/eas-build-job#getInstalledExpoPackageVersionAsync(...): node --print require.resolve('expo/package.json'), fs.readJson, semver validation, and the same EAS_BUILD_EXPO_PACKAGE_VERSION_* UserErrors.
  • collectMetadataAsync(...) now resolves expoPackageVersion inline with asyncResult(getInstalledExpoPackageVersionAsync(...)).value, so build creation and the existing internal updateBuildMetadata path send it alongside the rest of the build metadata.
  • Worker error-log tags now read expo_package_version from build metadata; the worker no longer resolves or mutates this field.

Test Plan

CI should pass.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.41%. Comparing base (99b18a2) to head (1781283).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/metadata.ts 42.86% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3725      +/-   ##
==========================================
+ Coverage   56.36%   56.41%   +0.06%     
==========================================
  Files         897      902       +5     
  Lines       38773    38857      +84     
  Branches     8059     8069      +10     
==========================================
+ Hits        21849    21919      +70     
- Misses      16818    16831      +13     
- Partials      106      107       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela changed the title Add expoPackageVersion to build metadata [eas-cli] Add expoPackageVersion to build metadata May 13, 2026
@sjchmiela sjchmiela force-pushed the stanley/expo-package-version-metadata-20260513 branch from d781da6 to cdbc01c Compare May 13, 2026 16:26
@sjchmiela sjchmiela marked this pull request as ready for review May 13, 2026 16:26
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela requested a review from szdziedzic May 13, 2026 17:09
@sjchmiela sjchmiela force-pushed the stanley/expo-package-version-metadata-20260513 branch from cdbc01c to 2c9952f Compare May 14, 2026 09:48
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit 6cbcc85 into main May 15, 2026
10 checks passed
@sjchmiela sjchmiela deleted the stanley/expo-package-version-metadata-20260513 branch May 15, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants