Skip to content

[auth] Make browser-based login the default#3746

Merged
byronkarlen merged 1 commit into
mainfrom
byron/_auth_make_browser-based_login_the_default
May 19, 2026
Merged

[auth] Make browser-based login the default#3746
byronkarlen merged 1 commit into
mainfrom
byron/_auth_make_browser-based_login_the_default

Conversation

@byronkarlen
Copy link
Copy Markdown
Contributor

@byronkarlen byronkarlen commented May 18, 2026

Why

Now that we have many third party login users (without passwords), it should be easier for them to log in through eas-cli.

How

Added --no-browser option to keep existing functionality intact, and made the --browser option the default.
This is a potentially breaking change (although I suspect for very few users) so updated changelog as such.

Test Plan

Manually tested eas login, eas login --browser, eas login --no-browser

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@byronkarlen byronkarlen force-pushed the byron/_auth_make_browser-based_login_the_default branch from 246875c to 8ff2b1a Compare May 18, 2026 23:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.99%. Comparing base (29909b2) to head (85ea594).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3746      +/-   ##
==========================================
+ Coverage   56.64%   56.99%   +0.36%     
==========================================
  Files         906      902       -4     
  Lines       39041    38874     -167     
  Branches     8154     8127      -27     
==========================================
+ Hits        22110    22154      +44     
+ Misses      15454    15263     -191     
+ Partials     1477     1457      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@byronkarlen
Copy link
Copy Markdown
Contributor Author

(although I suspect for very few users)

I obviously can't prove this, and I could be totally wrong if some of our customers happened to be using odd workarounds for eas login in CI. Is this a potentially large enough change to warrant a changelog post or something else to help our users out if this breaks stuff? IMO a major version upgrade is clear about breaking changes but wanted to bring up in case.

@byronkarlen byronkarlen force-pushed the byron/_auth_make_browser-based_login_the_default branch from 8ff2b1a to b9813b6 Compare May 19, 2026 00:02
@byronkarlen byronkarlen marked this pull request as ready for review May 19, 2026 00:12
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@byronkarlen byronkarlen requested a review from tchayen May 19, 2026 00:13
@byronkarlen byronkarlen force-pushed the byron/_auth_make_browser-based_login_the_default branch from b9813b6 to 85ea594 Compare May 19, 2026 15:53
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@byronkarlen byronkarlen merged commit 3024852 into main May 19, 2026
11 checks passed
@byronkarlen byronkarlen deleted the byron/_auth_make_browser-based_login_the_default branch May 19, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants