fix(eas-cli): Check if expo is resolvable before assuming it's installed#3748
Merged
Conversation
|
Subscribed to pull request
Generated by CodeMention |
sjchmiela
approved these changes
May 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3748 +/- ##
==========================================
+ Coverage 56.64% 56.99% +0.36%
==========================================
Files 906 902 -4
Lines 39041 38869 -172
Branches 8154 8124 -30
==========================================
+ Hits 22110 22149 +39
+ Misses 15454 15263 -191
+ Partials 1477 1457 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1b207de to
dbaa3f8
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We'll have to share a check on whether
expois resolvable withisExpoInstalled, to make it stricter, since the check is used to see ifexpois installed, not just to see if it's in dependencies. We often use this as a prerequisite to see if we can call the Expo CLI. The check needs to align withspawnExpoCommandto ensure we don't pass intospawnExpoCommandwhen we can'tTest Plan