Skip to content

fix(eas-cli): Check if expo is resolvable before assuming it's installed#3748

Merged
kitten merged 2 commits into
mainfrom
@kitten/fix/align-is-expo-installed-check
May 19, 2026
Merged

fix(eas-cli): Check if expo is resolvable before assuming it's installed#3748
kitten merged 2 commits into
mainfrom
@kitten/fix/align-is-expo-installed-check

Conversation

@kitten
Copy link
Copy Markdown
Member

@kitten kitten commented May 19, 2026

Summary

We'll have to share a check on whether expo is resolvable with isExpoInstalled, to make it stricter, since the check is used to see if expo is installed, not just to see if it's in dependencies. We often use this as a prerequisite to see if we can call the Expo CLI. The check needs to align with spawnExpoCommand to ensure we don't pass into spawnExpoCommand when we can't

Test Plan

@kitten kitten requested a review from sjchmiela May 19, 2026 09:36
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.99%. Comparing base (29909b2) to head (dbaa3f8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/project/projectUtils.ts 10.00% 9 Missing ⚠️
packages/eas-cli/src/utils/expoCli.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3748      +/-   ##
==========================================
+ Coverage   56.64%   56.99%   +0.36%     
==========================================
  Files         906      902       -4     
  Lines       39041    38869     -172     
  Branches     8154     8124      -30     
==========================================
+ Hits        22110    22149      +39     
+ Misses      15454    15263     -191     
+ Partials     1477     1457      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kitten kitten force-pushed the @kitten/fix/align-is-expo-installed-check branch from 1b207de to dbaa3f8 Compare May 19, 2026 09:54
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@kitten kitten merged commit 7ee81e8 into main May 19, 2026
7 checks passed
@kitten kitten deleted the @kitten/fix/align-is-expo-installed-check branch May 19, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants