Skip to content

[eas-cli] Improve iOS config fallback Sentry diagnostics#3763

Merged
sjchmiela merged 2 commits into
mainfrom
stanley/improve-ios-config-fallback-sentry
May 20, 2026
Merged

[eas-cli] Improve iOS config fallback Sentry diagnostics#3763
sjchmiela merged 2 commits into
mainfrom
stanley/improve-ios-config-fallback-sentry

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela commented May 20, 2026

Summary

  • capture an explicit iOS entitlements config fallback Sentry message so this fallback is easier to find than the generic spawn error
  • tag the event with app/build/config-resolution metadata
  • include spawn failure details in a JSON extra, preserving empty stdout/stderr as ""
  • add a changelog entry

Test plan

  • yarn workspace eas-cli typecheck
  • git diff --check

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela force-pushed the stanley/improve-ios-config-fallback-sentry branch 3 times, most recently from a6b338e to 1f6540a Compare May 20, 2026 16:21
@sjchmiela sjchmiela force-pushed the stanley/improve-ios-config-fallback-sentry branch from 1f6540a to 023d4f4 Compare May 20, 2026 16:23
@sjchmiela sjchmiela requested a review from AbbanMustafa May 20, 2026 16:25
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.83%. Comparing base (51fb25c) to head (f49d315).

Files with missing lines Patch % Lines
packages/eas-cli/src/project/ios/entitlements.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
+ Coverage   56.83%   56.83%   +0.01%     
==========================================
  Files         903      903              
  Lines       39058    39056       -2     
  Branches     8167     8167              
==========================================
  Hits        22193    22193              
+ Misses      15398    15396       -2     
  Partials     1467     1467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread CHANGELOG.md Outdated
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit ec0ac26 into main May 20, 2026
10 checks passed
@sjchmiela sjchmiela deleted the stanley/improve-ios-config-fallback-sentry branch May 20, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants