[eas-cli] improve naming for observe commands#3778
Merged
Conversation
|
Subscribed to pull request
Generated by CodeMention |
kadikraman
commented
May 21, 2026
|
|
||
| ### 🛠 Breaking changes | ||
|
|
||
| - [eas-cli] Rename observe commands: `observe:logs` → `observe:events` (events emitted via `logEvent`), previous `observe:events` → `observe:metrics` (individual performance metric samples), previous `observe:metrics` → `observe:metric-summary` (aggregated stats by app version). ([#3778](https://github.com/expo/eas-cli/pull/3778) by [@kadikraman](https://github.com/kadikraman)) |
Contributor
Author
There was a problem hiding this comment.
This is a breaking change, but there isn't really a way around it, and that's why we're in preview, right!
I think adding this here will create a major version will mean a major version bump when publishing - is that ok or should I put it in another section?
kadikraman
commented
May 21, 2026
| 'expo.app_startup.tti': 'Startup TTI', | ||
| 'expo.app_startup.ttr': 'Startup TTR', | ||
| 'expo.app_startup.bundle_load_time': 'Bundle Load', | ||
| 'expo.updates.download_time': 'Update Download', |
Contributor
Author
There was a problem hiding this comment.
Noticed this was missing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3778 +/- ##
==========================================
+ Coverage 56.83% 57.16% +0.33%
==========================================
Files 904 905 +1
Lines 39129 39284 +155
Branches 8178 8227 +49
==========================================
+ Hits 22237 22454 +217
+ Misses 15420 15358 -62
Partials 1472 1472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
douglowder
approved these changes
May 21, 2026
|
✅ Thank you for adding the changelog entry! |
kadikraman
added a commit
to expo/expo
that referenced
this pull request
May 26, 2026
# Why Resolves ENG-21384 Depends on expo/eas-cli#3778 <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How Add documentation for user-defined events in Observe. <!-- How did you build this feature or fix this bug and why? --> # Test Plan Review the docs on the preview or locally: http://localhost:3002/eas/observe/events/ <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of ENG-21384
The naming of our CLI commands does not match the website.
How
observe:metrics->observe:metrics-summaryobserve:events->observe:metricsobserve:logs->observe:eventsTest Plan
Manual and automated testing