[build-tools] Enable simulator accessibility prefs before boot#3914
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3914 +/- ##
==========================================
+ Coverage 59.05% 59.12% +0.07%
==========================================
Files 935 935
Lines 40954 40983 +29
Branches 8621 8629 +8
==========================================
+ Hits 24181 24226 +45
+ Misses 16678 16662 -16
Partials 95 95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a2aa55a to
7942a3b
Compare
7942a3b to
207f922
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_accessibility_settingsboolean input toeas/start_ios_simulator.IosSimulatorUtils.enableAccessibilitySettingsAsyncinline immediately before eachIosSimulatorUtils.startAsynccall, including cloned simulators.xcrun simctl list devices --json --no-escape-slashes availablewrapper so thedataPathfrom simctl JSON is used directly, then do an exact UDID/name equality check in JS. This avoidssimctlsearch-term substring matches likeiPhone 17matchingiPhone 17 Pro.UserError; wrap command/filesystem setup failures asSystemError.Why
These accessibility preferences help Argent and other AX-tree based tools inspect Simulator state more reliably. They can influence app/runtime accessibility behavior, so the setting is explicit and default-off rather than applied to every simulator startup.
Maestro compatibility
enable_accessibility_settingsdefaults tofalse, so existing Maestro test runs and othereas/start_ios_simulatorusers keep the previous startup behavior unless they opt in. When enabled, the setup only writes preferences for an exact, available, shutdown simulator beforesimctl bootstatus -b. If the requested simulator is not available or not shutdown, the step fails withUserError; if the setup command/filesystem work fails, it fails withSystemError.Notes
plutilis a standard macOS utility (/usr/bin/plutilon the local validation machine), so this does not add an external tool installation requirement.Validation
CI should pass.