Skip to content

[eas-build-job] remove unused field#3941

Open
wschurman wants to merge 1 commit into
mainfrom
07-02-_eas-build-job_remove_unused_field
Open

[eas-build-job] remove unused field#3941
wschurman wants to merge 1 commit into
mainfrom
07-02-_eas-build-job_remove_unused_field

Conversation

@wschurman

@wschurman wschurman commented Jul 2, 2026

Copy link
Copy Markdown
Member

Why

As far as I can tell, this field isn't set anywhere.

It was added in expo/eas-build#114.

Found this while trying to investigate fingerprint rtv policy issues with @AbbanMustafa. Trying to narrow investigation surface area.

For reviewers

If you know of any other way this could be set outside of this repo or www, let me know. As far as I can tell, graphql doesn't even accept other fields (AndroidJobVersionInput, for example).

How

Remove field from types. Propagate built types to server and run tsc to ensure they're not set there. Grep in org for version.runtimeVersion/version?.runtimeVersion and search for anywhere any sub-field of version is set. Only places I can find only set versionCode or buildNumber:

Test Plan

tsc

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman force-pushed the 07-02-_eas-build-job_remove_unused_field branch from 5894c90 to 399d587 Compare July 2, 2026 23:56
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@wschurman wschurman marked this pull request as ready for review July 2, 2026 23:56
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.28%. Comparing base (a848411) to head (399d587).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3941      +/-   ##
==========================================
+ Coverage   59.28%   59.28%   +0.01%     
==========================================
  Files         935      935              
  Lines       41093    41090       -3     
  Branches     8660     8658       -2     
==========================================
- Hits        24356    24355       -1     
+ Misses      16643    16641       -2     
  Partials       94       94              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant