[eas-build-job] remove unused field#3941
Open
wschurman wants to merge 1 commit into
Open
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5894c90 to
399d587
Compare
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3941 +/- ##
==========================================
+ Coverage 59.28% 59.28% +0.01%
==========================================
Files 935 935
Lines 41093 41090 -3
Branches 8660 8658 -2
==========================================
- Hits 24356 24355 -1
+ Misses 16643 16641 -2
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
As far as I can tell, this field isn't set anywhere.
It was added in expo/eas-build#114.
Found this while trying to investigate fingerprint rtv policy issues with @AbbanMustafa. Trying to narrow investigation surface area.
For reviewers
If you know of any other way this could be set outside of this repo or www, let me know. As far as I can tell, graphql doesn't even accept other fields (
AndroidJobVersionInput, for example).How
Remove field from types. Propagate built types to server and run tsc to ensure they're not set there. Grep in org for
version.runtimeVersion/version?.runtimeVersionand search for anywhere any sub-field ofversionis set. Only places I can find only set versionCode or buildNumber:Test Plan
tsc