Skip to content

feat: add ability to define a custom cache key invalidation version supplier#290

Merged
wschurman merged 1 commit intomainfrom
@wschurman/06-04-feat_add_ability_to_define_a_custom_cache_key_invalidation_version_supplier
Jun 6, 2025
Merged

feat: add ability to define a custom cache key invalidation version supplier#290
wschurman merged 1 commit intomainfrom
@wschurman/06-04-feat_add_ability_to_define_a_custom_cache_key_invalidation_version_supplier

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Jun 5, 2025

Why

This implements a mechanism so that applications may specify a custom strategy for cache key version invalidation, one example of which is #275 (comment)

How

Add a custom key version supplier function and expand the configuration.

Test Plan

Run the new test.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman force-pushed the @wschurman/06-04-feat_add_ability_to_define_a_custom_cache_key_invalidation_version_supplier branch from cfc37f8 to 741113a Compare June 5, 2025 04:02
@wschurman wschurman marked this pull request as ready for review June 5, 2025 04:02
@wschurman wschurman requested review from ide and quinlanj June 5, 2025 04:02
@wschurman wschurman force-pushed the @wschurman/06-04-feat_add_ability_to_define_a_custom_cache_key_invalidation_version_supplier branch from 741113a to 51c02f4 Compare June 5, 2025 04:04
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b9b0993) to head (51c02f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines         2229      2233    +4     
  Branches       272       273    +1     
=========================================
+ Hits          2229      2233    +4     
Flag Coverage Δ
integration 100.00% <100.00%> (ø)
unittest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman merged commit a3ab61b into main Jun 6, 2025
4 checks passed
@wschurman wschurman deleted the @wschurman/06-04-feat_add_ability_to_define_a_custom_cache_key_invalidation_version_supplier branch June 6, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants