Skip to content

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Nov 4, 2025

Why

Noticed this while working in the Expo server. Since this is an external interface created in application code, we want this generic to have a default (like other external interfaces).

Closes ENG-17962.

How

Add default.

Test Plan

yarn tsc

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman requested a review from quinlanj November 4, 2025 03:23
@wschurman wschurman marked this pull request as ready for review November 4, 2025 03:23
@linear
Copy link

linear bot commented Nov 4, 2025

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (59e024e) to head (2ba2faf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #316   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines        12100     12100           
  Branches      1036      1057   +21     
=========================================
  Hits         12100     12100           
Flag Coverage Δ
integration 7.85% <ø> (ø)
unittest 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman merged commit 2f9d487 into main Nov 5, 2025
4 checks passed
@wschurman wschurman deleted the wschurman/11-03-fix_add_default_for_tselectedfields_in_privacypolicytestutils_case branch November 5, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants