Skip to content

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Nov 11, 2025

Why

These were missing docblocks, and are something I often have to look up.

Closes ENG-18067.

How

Add docblocks.

Test Plan

tsdoc

Copy link
Member Author

wschurman commented Nov 11, 2025

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (30f4a62) to head (1c52288).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #319   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines        12100     12119   +19     
  Branches      1036      1036           
=========================================
+ Hits         12100     12119   +19     
Flag Coverage Δ
integration 7.83% <0.00%> (-0.02%) ⬇️
unittest 96.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman requested a review from quinlanj November 11, 2025 21:43
@wschurman wschurman marked this pull request as ready for review November 11, 2025 21:43
@linear
Copy link

linear bot commented Nov 11, 2025

Copy link
Member

@quinlanj quinlanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Member Author

wschurman commented Nov 12, 2025

Merge activity

  • Nov 12, 4:54 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 12, 5:00 PM UTC: Graphite rebased this pull request as part of a merge.
  • Nov 12, 5:03 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/11-11-chore_update_other_sibling_dependencies to graphite-base/319 November 12, 2025 16:55
@wschurman wschurman changed the base branch from graphite-base/319 to main November 12, 2025 16:58
@wschurman wschurman force-pushed the wschurman/11-11-chore_add_docblock_for_orderby_and_ordering branch from 8d136ac to 1c52288 Compare November 12, 2025 17:00
@wschurman wschurman merged commit 4559f8f into main Nov 12, 2025
4 checks passed
@wschurman wschurman deleted the wschurman/11-11-chore_add_docblock_for_orderby_and_ordering branch November 12, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants