fix: support number ID field generation in StubDatabaseAdapter#43
Merged
fix: support number ID field generation in StubDatabaseAdapter#43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 93.78% 93.82% +0.04%
==========================================
Files 55 55
Lines 1320 1329 +9
Branches 158 146 -12
==========================================
+ Hits 1238 1247 +9
Misses 81 81
Partials 1 1
Continue to review full report at Codecov.
|
quinlanj
approved these changes
Jun 10, 2020
| import AlwaysAllowPrivacyPolicyRule from '../rules/AlwaysAllowPrivacyPolicyRule'; | ||
|
|
||
| export type DateIDTestFields = { | ||
| id: Date; |
Member
Author
There was a problem hiding this comment.
the funny thing is that Date ids are probably not uncommon since they're fairly unique given enough precision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Most entities we have internally at Expo use UUID keys, so this was the default for
StubDatabaseAdapter. Supporting number keys is a requirement for most auto-increment systems.Closes #41.
How
Randomly generate a random number if the type of the ID field is a number. Decided to do random rather than simulating auto-increment as it's simpler.
Test Plan
Run new test with
yarn test.