fix(vm): handle non-comparable groupBy keys#940
Merged
antonmedv merged 1 commit intoexpr-lang:masterfrom Feb 28, 2026
Merged
Conversation
Check that the groupBy predicate result is comparable before using it as a map key. Previously, a non-comparable type such as a slice would cause a raw Go runtime panic. Now it produces a clear error message instead. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally reported in #939 through OSS-Fuzz with this input:
The
groupBy(0..3)evaluates to[]int{0, 1, 2, 3}for every element. ThegroupByresults are stored inmap[any][]anywhere the predicate result is used as the map key. And[]intis not comparable, thus the panic:Check that the
groupBypredicate result is comparable before using it as a map key. Now it produces a clear error message instead of a non-descriptive panic:Updated the allow list in the fuzz test harness.