Fix TTL=0 race: start new window at 1 atomically in Lua

[mt-ks]

• Problem: At TTL=0, INCR→PTTL ordering could let the counter continue instead of starting a new window.
• Fix: Lua increment now checks PTTL first; if TTL<=0, SET ... PX windowMs initializes the window at 1; otherwise INCR (and PEXPIRE when resetExpiryOnChange is true).
• Tests: Added unit test that stubs “key exists with PTTL=0”; existing tests pass.

Issue SS

[nfriedly]

Thank you, this is great work!

[nfriedly]

Thanks for making these named variables, we should have done that a while ago.

[nfriedly]

This does look like a much better fix than the original one, and it looks like I was wrong with my initial thinking that this was an unrelated issue.

I think using the SET PX argument bumps our minimum redis version to 2.6.12, up from 2.6.0 previously. I thought we had that documented somewhere, but I'm not seeing it now. Would you like to add a note to the readme calling that out? Maybe on the same line where it says the minimum node.js version?

Lastly, the linter is complaining about formatting - run npm run format to fix that automatically.

Then I can merge it in a publish a new release.

[mt-ks]

74208c0
Thx @nfriedly <3
Fix: 74208c0

[nfriedly]

Ok, CI should publish v4.2.3 to NPM shortly.

Thanks, again!

[mt-ks]

Feedback;
Tested, works perfect ✅

[nfriedly]

Hey @mt-ks you did an awesome job on this PR; would you like to be added to this repo as a co-maintainer with @gamemaker1 and myself? (And @wyattjoh who is the original author but no longer as involved in the project.)

We have a couple of changes planned (include a default redis library, & deprecate resetExpiryOnChange), and you'd be welcome but not obligated to take that on. My thinking is more that it would be beneficial to have someone involved who is currently using the library, in order to better anticipate and respond to issues.

[mt-ks]

Hi @nfriedly First of all, thank you
Absolutely, it’d be exciting to be part of this, and I’m looking forward to contributing and supporting the project! 🙌

[nfriedly]

Awesome, I just sent you an invite

[gamemaker1]

Welcome on board @mt-ks! Looking forward to working with you :)