Skip to content

Conversation

@danielcherubini
Copy link
Contributor

@danielcherubini danielcherubini commented Sep 29, 2017

Prop validation isn't available... it requires using the interface names and yeah that's gonna break string utils

@danielcherubini
Copy link
Contributor Author

This pull request introduces 2 alerts and fixes 1 - view on lgtm.com

new alerts:

  • 2 for Unused npm dependency

fixed alerts:

  • 1 for Unused npm dependency

Comment posted by lgtm.com

@danielcherubini danielcherubini added this to the v1.0.0 milestone Sep 29, 2017
@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #92 into develop will increase coverage by 0.07%.
The diff coverage is 95.34%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #92      +/-   ##
===========================================
+ Coverage    88.24%   88.32%   +0.07%     
===========================================
  Files           17       17              
  Lines          451      471      +20     
===========================================
+ Hits           398      416      +18     
- Misses          53       55       +2
Impacted Files Coverage Δ
src/utils/head.js 100% <100%> (ø) ⬆️
src/utils/string.js 96.82% <95.12%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02dfadb...1735e64. Read the comment docs.

@danielcherubini
Copy link
Contributor Author

This pull request introduces 2 alerts and fixes 1 - view on lgtm.com

new alerts:

  • 2 for Unused npm dependency

fixed alerts:

  • 1 for Unused npm dependency

Comment posted by lgtm.com

@danielcherubini danielcherubini merged commit a4f1dcb into develop Oct 6, 2017
@danielcherubini danielcherubini deleted the feature/source-string branch October 6, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants