refactor: move getCharset helper to only usage#707
Open
Phillip9587 wants to merge 1 commit intoexpressjs:masterfrom
Open
refactor: move getCharset helper to only usage#707Phillip9587 wants to merge 1 commit intoexpressjs:masterfrom
Phillip9587 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and uses optional chaining. In theory it short-circuits faster and by that avoids the empty string allocation and
.toLowerCase()call. But this is only in theory and probably highly optimized in engines.Same ideas as @Ayoub-Mabrouk in #557.