-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Release: 4.21.3 #6907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Release: 4.21.3 #6907
Conversation
|
Should we update |
|
@UlisesGascon If we release this we should actually release a Edit: We would also need to update |
|
Yes, and ideally the semver range updated to use |
|
for qs@6.14.0 expressjs/body-parser#664 |
|
@UlisesGascon I think there is some additional work needed before finalizing this release. Switching dependencies to use tilde notation causes several packages to be duplicated in our express v4 dependency tree. With the current changes, these packages end up duplicated in the graph:
To avoid this duplication, we should also update our own packages to use tilde version ranges. At minimum, these packages would require a release with updated ranges:
I can prepare PRs for these updates if this approach makes sense. |
|
For raw-body, I just created the v2 branch, which includes the changes up to the latest version of that line, and I’ve just opened the PR to use tilde notation in the dependencies (stream-utils/raw-body#126). Tomorrow or the day after I could make the release so that http-errors can already be deduplicated by raw-body. @Phillip9587 i think it makes sense for you to open the other PRs for the packages you mentioned. |
|
The deduplication of those dependencies doesn’t block this release, since we’re already using the tilde here in version 4, so there wouldn’t be any issue because of that. They can be handled as independent releases.” |
|
raw-body@2.5.3 has been released https://github.com/stream-utils/raw-body/releases/tag/2.5.3 |
|
I created all the necessary PRs to remove the dependency duplication. They are linked in the commet above. |
|
I think that I will convert this Release to semver-minor to support the security patch: https://github.com/expressjs/express/security/advisories/GHSA-pj86-cfqh-vqx6 and probably target Monday or Tuesday |
|
@UlisesGascon Please include #6919 in this release. cc @ljharb |
What's included in the
HISTORY.mdWhat's Changed
npm isteps to fix ci for older node versions by @Phillip9587 in ci: reordernpm isteps to fix ci for older node versions #6336Full Changelog: 4.21.2...4.x