Skip to content

Conversation

@UlisesGascon
Copy link
Member

What's included in the HISTORY.md

4.21.3 / 2025-11-21
==========

  * deps: use tilde notation for dependencies

What's Changed

Full Changelog: 4.21.2...4.x

@Phillip9587
Copy link
Member

Should we update qs for this release? I just saw that we are on 6.13.0 and there is a 6.13.1 and a 6.14.0 release?
cc @ljharb

@UlisesGascon UlisesGascon mentioned this pull request Nov 21, 2025
@Phillip9587
Copy link
Member

Phillip9587 commented Nov 21, 2025

@UlisesGascon If we release this we should actually release a body-parser 1.x update before which updates body-parsers dependencies to use tilde notation or we get dependency duplication problems accross our dependency graph.

Edit: We would also need to update qs for body-parser v1 or it is also duplicated.

@ljharb
Copy link

ljharb commented Nov 22, 2025

Yes, and ideally the semver range updated to use ^ as well.

@bjohansebas
Copy link
Member

for qs@6.14.0 expressjs/body-parser#664

@Phillip9587
Copy link
Member

Phillip9587 commented Nov 24, 2025

@UlisesGascon I think there is some additional work needed before finalizing this release.

Switching dependencies to use tilde notation causes several packages to be duplicated in our express v4 dependency tree. With the current changes, these packages end up duplicated in the graph:

  • send
  • statuses
  • http-errors
  • qs
  • encode-url

To avoid this duplication, we should also update our own packages to use tilde version ranges. At minimum, these packages would require a release with updated ranges:

I can prepare PRs for these updates if this approach makes sense.

@bjohansebas
Copy link
Member

For raw-body, I just created the v2 branch, which includes the changes up to the latest version of that line, and I’ve just opened the PR to use tilde notation in the dependencies (stream-utils/raw-body#126). Tomorrow or the day after I could make the release so that http-errors can already be deduplicated by raw-body.

@Phillip9587 i think it makes sense for you to open the other PRs for the packages you mentioned.

@bjohansebas
Copy link
Member

The deduplication of those dependencies doesn’t block this release, since we’re already using the tilde here in version 4, so there wouldn’t be any issue because of that. They can be handled as independent releases.”

@bjohansebas
Copy link
Member

raw-body@2.5.3 has been released https://github.com/stream-utils/raw-body/releases/tag/2.5.3

@Phillip9587
Copy link
Member

I created all the necessary PRs to remove the dependency duplication. They are linked in the commet above.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Nov 25, 2025

I think that serve-static , send and finalhandler can take a bit to be released based on expressjs/discussions#380, but I can try to program a release for body-parser@1.x.

I will convert this Release to semver-minor to support the security patch: https://github.com/expressjs/express/security/advisories/GHSA-pj86-cfqh-vqx6 and probably target Monday or Tuesday

@Phillip9587
Copy link
Member

@UlisesGascon Please include #6919 in this release. cc @ljharb

@UlisesGascon UlisesGascon mentioned this pull request Nov 25, 2025
@UlisesGascon UlisesGascon marked this pull request as draft November 25, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants