support NO_COLOR environment variable in dev format#344
Open
SAY-5 wants to merge 1 commit intoexpressjs:masterfrom
Open
support NO_COLOR environment variable in dev format#344SAY-5 wants to merge 1 commit intoexpressjs:masterfrom
SAY-5 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
The dev format now checks for the NO_COLOR environment variable (https://no-color.org/) and omits ANSI escape codes when it is set. This follows the community convention adopted by many CLI tools. Fixes expressjs#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev format now checks for the NO_COLOR environment variable
(https://no-color.org/) and omits ANSI escape codes when it is set.
When
NO_COLORis present inprocess.env, the dev format compiles aplain-text format string without any
\x1b[sequences and caches itunder a separate
'nocolor'key so colored and uncolored output don'tinterfere with each other.
Two new tests cover the behavior:
NO_COLORis setFixes #302