This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Fix warnings emitted by bindgen while building#22
Merged
expressvpn-pang-t merged 5 commits intomainfrom Mar 2, 2023
Merged
Conversation
`wrapper.h`, while the definitive version of the symbols we want to generate bindings for, pulls in numerous other symbols that we don't really care for (for example various `*printf` methods from `stdio.h`). An attempt was made to resolve this by blocking `stdlib.h` (now no longer necessary), but in this case it's likely better to more tightly control the list of allowed headers via the `allowlist_file` mechanism instead. We don't build for openssl compatibility support, so don't expose the `openssl/` headers. Except for `compat_types.h`, which is required by other wolfssl bits.
It was generating the following warning on
`aarch64-unknown-linux-gnu`:
```
warning: `extern` block uses type `[u64; 4]`, which is not FFI-safe
--> /wolfssl-sys/target/debug/build/wolfssl-sys-effcdb54711168e1/out/bindings.rs:10676:15
|
10676 | args: va_list,
| ^^^^^^^ not FFI-safe
|
= help: consider passing a pointer to the array
= note: passing raw arrays by value is not FFI-safe
= note: `#[warn(improper_ctypes)]` on by default
```
It might be the case that there are other unnecessary binding
generation that we missed, but the aim is to make the project build
cleanly first.
Merged
expressvpn-pete-m
approved these changes
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.