This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Merged
Conversation
Bindgen removed `Bindings::emit_warnings` in 0.65 [0] and rolled it
into the `bindgen-cli` interface under the `--emit-diagnostics` flag,
so update `build.rs` accordingly.
Also resolve deprecation warning
```
warning: use of deprecated method `bindgen::options::<impl bindgen::Builder>::rustfmt_bindings`
--> build.rs:163:10
|
163 | .rustfmt_bindings(true);
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
```
[0]: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#0650
At some point the C-side of the liboqs build started emitting warnings
of the following nature:
```
error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
OQS_KEM *OQS_KEM_bike_l3_new() {
^
void
```
The fix is currently in an unreleased branch in `liboqs-rust`, so pin
to a known good commit.
Bumping WolfSSL to 5.6.0 now causes `./configure` to require `colrm` to be present on the machine. Install it as a dependency.
- `-qq` implies `-y`, so `-qqy` is redundant. - Append `--no-install-recommends` to reduce the size and time spent installing dependencies.
expressvpn-pang-t
requested review from
expressvpn-brendan-h and
expressvpn-pete-m
as code owners
expressvpn-pete-m
approved these changes
Apr 26, 2023
expressvpn-pang-t
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the following:
0.7.2(released last year) but the fix for the issue we're experiencing is fairly recent.cargo outdatedstates onlybindgen 0.64 -> 0.65)On a machine with the following specs:
earthly version v0.7.4 a1c46ca2b75f21a4948fd53b5464de5a2bd90372 darwin/arm64; macOS 13.1 homebrewEarthfile)Running
earthly +build-devresults in build-logs.txt on the machine. It's discovered (later on) that this is becausecolrmmust now be present on the build machine. This change seems to be a result of the bump to WolfSSL 5.6.0.