Skip to content

[BUGFIX] Move module configuration to page.tsconfig #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-g-codappix merged 2 commits into from
Jan 29, 2026
Merged

[BUGFIX] Move module configuration to page.tsconfig #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8c05f1
[BUGFIX] Move module configuration to page.tsconfig
d-g-codappix Jan 29, 2026
dc52d5d
[BUGFIX] Add check for empty format configuration
d-g-codappix Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/ViewHelpers/Format/CurrencyViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public function render(): string

$settings = $this->templateVariableContainer->get('settings');

if ($settings && $settings['format'] && $settings['format']['currency']) {
if (isset($settings['format']['currency']) && is_array($settings['format']['currency'])) {
$currencyFormat = $settings['format']['currency'];

if (!isset($currencySign) && isset($currencyFormat['currencySign'])) {
Expand Down
21 changes: 21 additions & 0 deletions Configuration/page.tsconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,23 @@
# Template path for dashboard widgets
templates.typo3/cms-dashboard.1712899110 = extcode/cart:Resources/Private/

tx_cart {
persistence {
storagePid = {$module.tx_cart.persistence.storagePid}
}

settings {
format.currency {
currencySign = {$plugin.tx_cart.settings.format.currency.currencySign}
decimalSeparator = {$plugin.tx_cart.settings.format.currency.decimalSeparator}
thousandsSeparator = {$plugin.tx_cart.settings.format.currency.thousandsSeparator}
prependCurrency = {$plugin.tx_cart.settings.format.currency.prependCurrency}
separateCurrency = {$plugin.tx_cart.settings.format.currency.separateCurrency}
decimals = {$plugin.tx_cart.settings.format.currency.decimals}
}

backend {
dateFormat = {$plugin.tx_cart.settings.backend.dateFormat}
}
}
}
21 changes: 0 additions & 21 deletions ext_typoscript_setup.typoscript
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,3 @@
module.tx_cart {
persistence {
storagePid = {$module.tx_cart.persistence.storagePid}
}

settings {
format.currency {
currencySign = {$plugin.tx_cart.settings.format.currency.currencySign}
decimalSeparator = {$plugin.tx_cart.settings.format.currency.decimalSeparator}
thousandsSeparator = {$plugin.tx_cart.settings.format.currency.thousandsSeparator}
prependCurrency = {$plugin.tx_cart.settings.format.currency.prependCurrency}
separateCurrency = {$plugin.tx_cart.settings.format.currency.separateCurrency}
decimals = {$plugin.tx_cart.settings.format.currency.decimals}
}

backend {
dateFormat = {$plugin.tx_cart.settings.backend.dateFormat}
}
}
}

config.pageTitleProviders {
cart {
provider = Extcode\Cart\PageTitle\PageTitleProvider
Expand Down