Fix Integration tests add DISABLE_DATABASE_DUMP flag#136
Merged
sprankhub merged 1 commit intoextdn:masterfrom Oct 16, 2025
Merged
Fix Integration tests add DISABLE_DATABASE_DUMP flag#136sprankhub merged 1 commit intoextdn:masterfrom
sprankhub merged 1 commit intoextdn:masterfrom
Conversation
I think this should fix extdn#134 I never extract this database dump from the github action anyway, so turning it off is no great loss (and may actually speed things up by a few seconds?). I have verified this process by bodging in the `sed` hack via `magento_post_install_script` which can be seen here convenient/magento-broken-integration-tests-events#2
convenient
changed the title
sprankhub
approved these changes
Oct 16, 2025
Collaborator
sprankhub
left a comment
sprankhub
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I don't like the core hack, but I also don't see a better option. And I absolutely agree that we don't need the dump, as it wouldn't be re-used in CI anyway.
Contributor
Author
|
@sprankhub my tests are now going green without my hack. This should resolve #134 convenient/magento-broken-integration-tests-events#3 Agreed, I am far from in love with this code change, I initially looked for some flag to stop magento dumping but AFAIK this is always hardcoded to be enabled. Another workaround could have been to put in a "fake" empty dump file at the expected location so that it thinks the dump exists and doesn't do it? But either way, we're dealing with side effects of the system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should fix #134
I never extract this database dump from the github action anyway, so turning it off is no great loss (and may actually speed things up by a few seconds?).
I have verified this process by bodging in the
sedhack viamagento_post_install_scriptwhich can be seen here convenient/magento-broken-integration-tests-events#2