feat: Health handling#70
Merged
Merged
Conversation
sasjo
reviewed
May 20, 2026
sasjo
left a comment
sasjo
left a comment
There was a problem hiding this comment.
I think we can simplify and rely on default mapping paths.
| * @param outcome overall outcome; {@code "Up"} (case-insensitive) means healthy | ||
| * @param dependencies per-dependency statuses; {@code null} is normalised to an empty list | ||
| */ | ||
| public record HealthOutcome(String outcome, List<Dependency> dependencies) { |
There was a problem hiding this comment.
Why not boolean outcome and let the "wireshape" translate it to outcome "Up"?
There was a problem hiding this comment.
Why do we "hand roll" a serializer/renderer for health checks instead of relying on the Gson mapper we anyway will fallback to? This renderer means you cannot serve health as anything but application/json.
I don't have any issues with this being quite similar to regular request handlers where it's quite predictable how they'd encode the data.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.