externpro devel package #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp .devcontainer/cmake/presets/CMakePresets* .
CMake Error at CMakeLists.txt:39 (add_library): add_library cannot create ALIAS target "GTest::gtest" because another target with the same name already exists. `add_subdirectory(third_party/gtest EXCLUDE_FROM_ALL)` defines the alias target
Address Clang warnings in the test suite without weakening the test coverage: - LuaRefTests.Assignment: Avoid -Wself-assign-overloaded by assigning from a copy of LuaRef instead of using literal `value = value;`, while still verifying that assignment preserves the value. - PerformanceTests: Add a virtual destructor to struct A so Clang no longer warns about deleting a polymorphic type without a virtual destructor. - RefCountedObjectTests.AssignOperatorRefSelfAssignment RefCountedPtrTests.AssignOperatorRefSelfAssignment: Restore true self-assignment tests for RefCountedObjectPtr and RefCountedPtr, but wrap the self-assignment line in Clang diagnostic pragmas that temporarily disable -Wself-assign-overloaded. These changes keep the original semantics of the tests intact while allowing Release builds with -Wall -Werror under Clang to pass cleanly.
Wrap weak_ptr expiration checks in StdFunctions-related tests with a LUABRIDGE_CHECK_STDFUNCTION_LIFETIME guard. This keeps the behavioral checks that: - std::function-based methods/properties are callable from Lua, and - their shared_ptr captures remain alive while Lua holds them, but stops requiring that captured shared_ptrs expire immediately after lua_close() on all platforms. Strict lifetime checking can still be enabled by defining LUABRIDGE_CHECK_STDFUNCTION_LIFETIME when building the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue externpro/externpro#259