externpro 26.01-39-gabd7f93#6
Merged
Merged
Conversation
https://cmake.org/cmake/help/latest/module/FindThreads.html#result-variables Add checks for CMake thread-related variables. This includes: - CMAKE_THREAD_LIBS_INIT - CMAKE_USE_WIN32_THREADS_INIT - CMAKE_USE_PTHREADS_INIT - CMAKE_HP_PTHREADS_INIT These variables are appended to reqVars so thread configuration is visible in PARENT_SCOPE from xpFindPkg().
smanders
added
dependencies
smanders
commented
May 19, 2026
| "endif()" | ||
| "if(CMAKE_USE_PTHREADS_INIT)" | ||
| " list(APPEND reqVars CMAKE_USE_PTHREADS_INIT)" | ||
| "endif()" |
Contributor
Author
There was a problem hiding this comment.
this fixes googletest cmake https://github.com/externpro/googletest/blob/xpv1.16.0.3/googletest/cmake/internal_utils.cmake#L65-L69
# Defines CMAKE_USE_PTHREADS_INIT and CMAKE_THREAD_LIBS_INIT.
find_package(Threads)
if (CMAKE_USE_PTHREADS_INIT)
set(GTEST_HAS_PTHREAD ON)
endif()now the result variables are in PARENT_SCOPE (see commit message dbde521 for details) and GTEST_HAS_PTHREAD is ON and Threads::Threads is linked into googletest (aka GTest) libraries (as it was before externpro/Threads was a thing... before CPS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01-39-gabd7f93Changes
.devcontainerto externpro26.01-39-gabd7f93525879fbc7ec94170cb673e9cca4c5aefe042488abd7f93561875101f61ef8e3168500e92603a5b8.github/release-tag.json(tag:xpv1.0.4)Workflow Update Report
jobs.linux.with.cmake_workflow_preset_suffixjobs.macos.with.cmake_workflow_preset_suffixjobs.windows.with.cmake_workflow_preset_suffixThis PR was created automatically by GitHub Actions