externpro 26.01.1-45-g37c6f25#6
Merged
Merged
Conversation
- Update minimum CMake version from 3.31 to 4.3 - Remove XP_NAMESPACE and xproinc.cmake inclusion (now part of CMakePresets) - Package name and Target Namespace now match - Make xpExternPackage conditional 'if(COMMAND' - Repo's hdf5-config installed as hdf5-config-orig - see externpro/externpro#308 (comment) - avoid collision with xpExternPackage() installed hdf5-config - Auto-infer dependencies (zlib) - xpExternPackage NO_EXPORT because target_link_libraries has PUBLIC generator expression - see error message below - disable CPS and SBOM, for now CMake Error in src/CMakeLists.txt: Property "INTERFACE_LINK_LIBRARIES" of target "hdf5-static" contains a generator expression. This is not allowed.
smanders
added
dependencies
Author
|
issue externpro/externpro#322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.1-45-g37c6f25Changes
.devcontainerto externpro26.01.1-45-g37c6f258a5e4df7220b4870ba0ff81ee9e2b319b285597737c6f25041606bc49737abe4228d316daccd386exprodeps.md.github/release-tag.json(tag:xpv1.14.6.8)Workflow Update Report
CMakePresets.json
.devcontainer/cmake/presets/xpWindowsVs2022.jsoninclude and stagedCMakePresets.jsonThis PR was created automatically by GitHub Actions