Conversation
…rnPackage - Use `if(COMMAND xpExternPackage)` instead of `if(DEFINED XP_NAMESPACE)` to detect externpro environment - Remove XP_NAMESPACE cache variable from CMakePresetsBase.json - Simplify xpExternPackage call by removing deprecated NAMESPACE and ALIAS_NAMESPACE params - Fix namespace references to use hardcoded "spdlog::" to match upstream This change makes the externpro integration more robust by checking for the command's existence rather than relying on a variable being set. issue externpro/externpro#307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: replace XP_NAMESPACE variable with COMMAND check for xpExternPackage
if(COMMAND xpExternPackage)instead ofif(DEFINED XP_NAMESPACE)to detect externpro environmentThis change makes the externpro integration more robust by checking for the command's existence rather than relying on a variable being set.