New action key: ban an image, video or audio track#1505
Merged
GrosPoulet merged 1 commit intoextesy:masterfrom Dec 15, 2024
Merged
New action key: ban an image, video or audio track#1505GrosPoulet merged 1 commit intoextesy:masterfrom
GrosPoulet merged 1 commit intoextesy:masterfrom
Conversation
A new action key (default value: "B") can be used to prevent an image, video or audio track from being zoomed (and played) next time it is hovered. Ban is not lifted by just restarting browser. So in Advanced options, a new button is available in order to reset banned items so they can be zoomed again.
|
Owner
|
@GrosPoulet This is a curious feature. What is the use case? Why would you want to ban a single image but not an entire website? |
Contributor
Author
|
@extesy This curious feature will be useful when i push improvments that will result in more images being zoomed, including background images. And sometimes, depending on website design, a background image "gets in the way", so user can ban it, et voilà! |
Owner
|
Be careful with that. Most users won't know about the "ban a single image" feature and when background images suddenly begin to unexpectedly pop up everywhere, it will be very annoying to many users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new action key (default value: "B") can be used to prevent an image, video or audio track from being zoomed (and played) next time it is hovered.
Ban is not lifted by just restarting browser. So in Advanced options, a new button is available in order to reset banned items so they can be zoomed again.