Fix: images showing when mouse is off image link

[LiliaDoe]

• This might fix the issue described in Add mouse click action key for right/middle mouse button #1489 (comment)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[extesy]

This PR fixed the problem, so I'm merging it.

[LiliaDoe]

Glad to hear!

[extesy]

@LiliaDoe I spoke too soon, I'm still seeing this problem. Repro steps (can repro on reddit as well but this one is easier):

1. Open https://forums.crateentertainment.com/t/announcing-fangs-of-asterkarn/129879
2. Set "delay before displaying a picture" to some reasonably high value.
3. Briefly move the cursor into the picture and immediately move it far away.

Observed: the zoomed mage is still displayed even though the mouse is no longer hovering over it.
Desired: only display the image if the mouse is hovering over it.

[LiliaDoe]

Ok, I can reproduce it consistently now.

[LiliaDoe]

I believe I found the source of the issue:

hoverzoom/js/hoverzoom.js

Lines 1074 to 1086 in 4cb6b61

	if (audioSrc) {
	chrome.runtime.sendMessage({action:'isImageBanned', url:audioSrc}, function (result) {
	if (!result) {
	loadFullSizeImageTimeout = setTimeout(loadFullSizeImage, delay);
	}
	});
	} else if (src) {
	chrome.runtime.sendMessage({action:'isImageBanned', url:src}, function (result) {
	if (!result) {
	loadFullSizeImageTimeout = setTimeout(loadFullSizeImage, delay);
	}
	});
	}

changing it back to how it was prior made it behave as expected for me:

hoverzoom/js/hoverzoom.js

Lines 1071 to 1074 in 6b9717e

	// if the action key has been pressed over an image, no delay is applied
	const delay = actionKeyDown || explicitCall ? 0 : (isVideoLink(srcDetails.url) ? options.displayDelayVideo : options.displayDelay);
	loadFullSizeImageTimeout = setTimeout(loadFullSizeImage, delay);

While it's not from my commit, I will work on a fix for it.

[extesy]

Thank you for finding the root cause. I thought I bi-sected the problem to your commit, but I guess I made a mistake while doing that. Please accept my apologies!