Skip to content

Add migrate old settings button#1546

Merged
extesy merged 5 commits intoextesy:masterfrom
LiliaDoe:Add-Migrate-Old-Settings-Button
Feb 23, 2025
Merged

Add migrate old settings button#1546
extesy merged 5 commits intoextesy:masterfrom
LiliaDoe:Add-Migrate-Old-Settings-Button

Conversation

@LiliaDoe
Copy link
Copy Markdown
Contributor

@LiliaDoe LiliaDoe commented Feb 22, 2025

  • Should be a fix for those who's settings didn't migrate
  • Working on a fix to migrate options function too

@LiliaDoe
Copy link
Copy Markdown
Contributor Author

localStorage returns undefined, and I'm not sure if that's fixable. I'm closing this until this I figure that out

@LiliaDoe LiliaDoe closed this Feb 22, 2025
@LiliaDoe LiliaDoe reopened this Feb 22, 2025
@LiliaDoe
Copy link
Copy Markdown
Contributor Author

LiliaDoe commented Feb 22, 2025

I figured out the storage system for a temporary addon was different than a signed addon in firefox, which caused my error. After fixing that part, the manual migrate button worked as expected.

That said, if you could look through the option for it to make sure it looks how you'd like it, that'd be great! I added a warning to the button, since pressing it will overwrite the user's current settings:
image

If you think the warning unnecessary, I'll take it off. It's in the tooltip as well, so it might be redundant

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@extesy
Copy link
Copy Markdown
Owner

extesy commented Feb 23, 2025

Looks great, thank you!

@extesy extesy merged commit 2967282 into extesy:master Feb 23, 2025
@LiliaDoe LiliaDoe deleted the Add-Migrate-Old-Settings-Button branch February 23, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants