Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hello @extesy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the translation files for the application in multiple languages (am, ar, bg, bn, ca, cs, da, de, el, es, et, fa, fi, fil, fr, gu, he, hi, hr, hu, id, it, ja, kn, ko, lt, lv, ml, mr, ms, nl, no, pl, pt_BR, pt_PT, ro, ru, si, sk, sl, sr, sv, sw, ta, te, th, tr, uk, vi, zh_CN, zh_TW). The changes involve adding new options and tooltips, modifying existing ones, and updating translations for existing strings. Specifically, new options related to image zoom factor, locked image zooming, viewer shadows, caption details, and offset units have been added. The toolbar icon changing logic has also been updated. The translations are managed through Crowdin.
Highlights
- New Options and Tooltips: Several new options and corresponding tooltips have been added, including those related to lock image zoom factor, default zoom for locked images, viewer shadows, and caption detail shadows. These additions enhance the application's configurability.
- Offset Unit Customization: The pull request introduces the ability to choose between pixel (px) and percentage (%) based units for offset amounts, providing more flexibility in adjusting text positions.
- Toolbar Icon Logic Update: The logic for changing the toolbar icon based on image zoom capabilities has been updated, providing a more intuitive user experience.
- Translation Updates: The core of this PR is to update translations across a wide range of languages, ensuring the application is localized effectively. This includes new strings and modifications to existing ones.
Changelog
Click here to see the changelog
- _locales/am/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ar/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/bg/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/bn/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ca/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/cs/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/da/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/de/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/el/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/es/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/et/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/fa/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel or percentage based units for offset amounts.
- _locales/fi/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/fil/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/fr/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/gu/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel or percentage based units for offset amounts.
- _locales/he/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/hi/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/hr/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/hu/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/id/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/it/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ja/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/kn/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ko/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/lt/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/lv/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ml/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/mr/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ms/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/nl/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/no/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/pl/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/pt_BR/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/pt_PT/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ro/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/sk/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/sl/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/sr/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/sv/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/sw/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/ta/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/te/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/th/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel or percentage based units for offset amounts.
- _locales/tr/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/uk/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel or percentage based units for offset amounts.
- _locales/vi/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel or percentage based units for offset amounts.
- _locales/zh_CN/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
- _locales/zh_TW/messages.json
- Added new options and tooltips related to image zoom factor and locked image zooming.
- Updated translations for toolbar icon changing logic.
- Added new options for enabling viewer and caption detail shadows.
- Added options to choose between pixel and percentage based units for offset amounts.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The field of translation and localization is supported by a wide array of CAT (Computer-Assisted Translation) tools, which help translators manage terminology, leverage previous translations, and ensure consistency across large projects.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new Crowdin updates, primarily focusing on adding translations for new features and options across various languages. The changes involve adding new message keys and updating existing ones in the messages.json files for each language. Overall, the changes seem straightforward and consistent.
Summary of Findings
- Inconsistent Tooltip Descriptions: Several tooltip descriptions lack clarity regarding the direction of value changes (positive/negative) for offset options. While some descriptions explicitly mention the effect of positive and negative values, others do not, leading to potential user confusion. This inconsistency should be addressed for a better user experience.
- Missing Context for 'Use zoom factor for lock image': The purpose and functionality of the 'Use zoom factor for lock image' option and its associated tooltip are not immediately clear. More context or a clearer explanation might be needed to ensure users understand its impact.
Merge Readiness
The pull request is primarily focused on translation updates, and the changes appear to be consistent across different languages. However, the issues identified regarding the clarity of tooltip descriptions and the context for the 'Use zoom factor for lock image' option should be addressed before merging. Addressing these points will improve the user experience and ensure that the new features are easily understood. I am unable to directly approve this pull request, and recommend that other reviewers verify the changes and approve before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.