Conversation
Summary of ChangesHello @extesy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the latest localization updates from Crowdin, primarily introducing new translation keys for a 'Scrollwheel cooldown' feature and refining existing German translations for various UI elements and functionalities. These changes ensure the application's user interface remains accurately translated and consistent across multiple languages. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request from Crowdin adds new localization keys and updates some existing translations. However, I've noticed that for many languages, the new keys (optScrollWheelCooldown, optScrollWheelCooldownTooltip, optScrollWheelCooldownUnit) have been added with English placeholder text instead of the proper translations. This will result in a mixed-language user interface for non-English users, which can be confusing. I've left a few comments on specific files as examples, but this issue is present across most of the updated locale files. It's important to ensure these new strings are translated before this is merged to maintain a consistent and high-quality user experience.
| "optScrollWheelCooldown": { | ||
| "message": "Scrollwheel cooldown:", | ||
| "description": "[options] Mouse scroll wheel cooldown" | ||
| }, | ||
| "optScrollWheelCooldownTooltip": { | ||
| "message": "Amount of time required between mouse scroll events before another action is triggered", | ||
| "description": "[options] Tooltip for mouse scrollwheel delay" | ||
| }, | ||
| "optScrollWheelCooldownUnit": { | ||
| "message": "milliseconds", | ||
| "description": "[options] Unit name (pixel) for hold time amount" | ||
| }, |
There was a problem hiding this comment.
The newly added localization keys have not been translated into Amharic. They are currently using the English source strings. This will cause English text to be displayed to users. Please ensure all new strings are translated.
| "optScrollWheelCooldown": { | ||
| "message": "Scrollwheel cooldown:", | ||
| "description": "[options] Mouse scroll wheel cooldown" | ||
| }, | ||
| "optScrollWheelCooldownTooltip": { | ||
| "message": "Amount of time required between mouse scroll events before another action is triggered", | ||
| "description": "[options] Tooltip for mouse scrollwheel delay" | ||
| }, | ||
| "optScrollWheelCooldownUnit": { | ||
| "message": "milliseconds", | ||
| "description": "[options] Unit name (pixel) for hold time amount" | ||
| }, |
There was a problem hiding this comment.
While other strings in this file have been updated with German translations, the newly added keys for optScrollWheelCooldown, optScrollWheelCooldownTooltip, and optScrollWheelCooldownUnit are still in English. This will lead to an inconsistent, mixed-language experience for users. Please provide the German translations for these new keys.
| "optScrollWheelCooldown": { | ||
| "message": "Scrollwheel cooldown:", | ||
| "description": "[options] Mouse scroll wheel cooldown" | ||
| }, | ||
| "optScrollWheelCooldownTooltip": { | ||
| "message": "Amount of time required between mouse scroll events before another action is triggered", | ||
| "description": "[options] Tooltip for mouse scrollwheel delay" | ||
| }, | ||
| "optScrollWheelCooldownUnit": { | ||
| "message": "milisegundos", | ||
| "description": "[options] Unit name (pixel) for hold time amount" | ||
| }, |
There was a problem hiding this comment.
This change introduces new strings, but some are not translated to Spanish. Specifically, optScrollWheelCooldown and optScrollWheelCooldownTooltip are still in English, while optScrollWheelCooldownUnit is translated. This will result in a mixed-language UI. Please ensure all new strings are fully translated.
1 participant
No description provided.