Support for BinarySlice to avoid allocation #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For optimized applications where we need to read binary data (for example calculating checksums), I propose to add a new type
BinarySlice<T>along the currentBinary<T>in order to avoid allocation/copying. This type can only be used as a parameter and not return value on the Rust side, since modifying the binary string is not allowed. For our usage, this improves the running time by about -20%.Up for discussion: should we keep this in
binary_sliceor move it tobinary?Please let me know if there is a need for additional documentation somewhere.