Skip to content

Conversation

@joehoyle
Copy link
Collaborator

This is much the same as php_class(name="ABC")

@striezel
Copy link
Contributor

striezel commented Sep 29, 2022

@joehoyle: You might want to rebase your changes on top of the current master branch to get rid of those clippy warnings. I guess the automated checks should pass then.

@joehoyle
Copy link
Collaborator Author

@striezel @ptondereau ok can do-- I wanted to check if anyone have merge capabilities though? As I wasn't sure how abandoned the project is right now. Are either of you happy / able to merge things?

@ptondereau
Copy link
Member

For the moment, only @TobiasBengtsson have the merge right. But for us, we just review the PR.

This is much the same as `php_class(name="ABC")`
@joehoyle joehoyle force-pushed the add-name-function-macro branch from 561f6ae to 18ede97 Compare September 30, 2022 10:01
@joehoyle
Copy link
Collaborator Author

@TobiasBengtsson ok this should be good now.

@TobiasBengtsson
Copy link
Collaborator

Thanks! It would be nice to have more maintainers in fact, since I don't have that much time. See #140 and email David if you're interested @striezel @ptondereau

@TobiasBengtsson TobiasBengtsson merged commit 73902ef into extphprs:master Sep 30, 2022
@joehoyle joehoyle deleted the add-name-function-macro branch July 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants