Skip to content

Replaced manual TryFrom implementations with macro #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidcole1340 merged 2 commits into from
Apr 18, 2021
Merged

Replaced manual TryFrom implementations with macro #24

davidcole1340 merged 2 commits into from
Apr 18, 2021

Conversation

@davidcole1340
Copy link
Collaborator

@davidcole1340 davidcole1340 commented Apr 18, 2021

  • Replaced manual TryFrom implementations on Zval with a generic macro. Using this implemented on most types.
  • Zval::set_long, Zval::set_double and Zval::set_bool now accept any type which implements Into<T> where T is the type that the function originally took.

@davidcole1340 davidcole1340 merged commit d4c6aa2 into master Apr 18, 2021
@davidcole1340 davidcole1340 deleted the zval_traits branch May 3, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidcole1340