feat(iterator): add helper for zend_object_iterator and iterable type #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only support throwing exception class entries, i.e. stateless exceptions. Ideally we also want to support throwing a ZVal which has a ClassEntry that extends the Exception PHP class. This can be used to throw stateful exceptions which is not uncommon. This PR is missing one piece: `throw_object` will currently `drop` the Zval when the function is completed, causing reference / null pointer errors. It seems `ZVal::Drop` doesn't actually free the zval currently, it just sets the type to NULL (which also breaks things.) Discussed briefly in https://discord.com/channels/115233111977099271/1025314959179120714 on how best to solve this, but I'm not totally clear still! Ideally I think we want `throw_object` to own the `zval` but not free it once the function returns.
This is akin to ExecutorGlobals, but for the process globals
Add support for SapiGlobals
This allows extensions to register and unregister custom stream wrappers
Add helper to get the sapi name
Add support for Zval IS_INDIRECT
…ject Add support for throwing Exception objects
Add function type helper function
Add helper method for function table
Add streams API, ProcessGlobals, FileGlobals and SapiGlobals
danog
approved these changes
Nov 24, 2023
Collaborator
|
Changed my mind on the design a bit, refactoring... |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is wanted, so this is a first shot into adding a
ZendIteratortype to handle all objects that have an iterator and allow custom extension to use them in a more friendly wayIt should work for any class that extends
Traversable, but not for array, a super type may be needed if we want to supportiterabletype : which is mainly either an array or a TraversableTODO: