chore(php): add deprecation warning for php 8.0 #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenira
changed the title
Xenira
force-pushed
the
deprecate-php-8_0
branch
from
c8910bc to
d724204
Compare
|
I'd vote for "not supported" but I don't know we need to actively not allow compiling against php 8. There's also the reality of how many people may still be running PHP 8 as well as whether it's supported or not. So, I'd say: let's remove CI for PHP 8 (after deprecating it) etc, but don't actively disallow it. |
|
Fair point. Will change the warning message and docs accordingly. |
Xenira
force-pushed
the
deprecate-php-8_0
branch
from
d724204 to
b9e42db
Compare
Xenira
force-pushed
the
deprecate-php-8_0
branch
from
b9e42db to
051c185
Compare
|
@joehoyle like this? |
joehoyle
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #343