chore(test): fix embed test on php 8.4 #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Guess the pipeline should also run embedded for all supported php versions. Not necessarily in this pr though. Will have a closer look at the changes once I am back from work. |
Contributor
Author
|
Yeah that's what i think so also, i try to look at the possibility of passing a build var to the dockerfile but did not see it (would avoid duplicating dockerfile) |
Xenira
requested changes
Mar 10, 2025
Member
Xenira
left a comment
Xenira
left a comment
There was a problem hiding this comment.
Looks good to me. Just 2 small nitpicks. Thank you!
Xenira
approved these changes
Mar 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_register_module_exchange its signature in php 8.4