feat(error): deprecate E_USER_ERROR in PHP 8.4
#485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
approved these changes
Jul 4, 2025
|
Only problem is that I can't get Haven't done much with embed. Need to investigate more tomorrow. |
|
Not sure if there actually is a good way. Looking at php testcases they now have that same deprecation warning in expected output... |
Xenira
force-pushed
the
476-passing-e_user_error-to-trigger_error-is-deprecated-since-84
branch
2 times, most recently
from
d0eb529 to
fe67771
Compare
Xenira
commented
Jul 5, 2025
.lefthook.yml
Outdated
| jobs: | ||
| - name: fmt | ||
| run: rustfmt {staged_files} | ||
| run: rustfmt --edition 2024 {staged_files} |
There was a problem hiding this comment.
This is required for c string literals.
There was a problem hiding this comment.
Uff, guess that changed formatting rules for imports
There was a problem hiding this comment.
Ok, 2021 (same as Cargo.toml) works
Pull Request Test Coverage Report for Build 16087509071Details
💛 - Coveralls |
Xenira
force-pushed
the
476-passing-e_user_error-to-trigger_error-is-deprecated-since-84
branch
from
fe67771 to
45b832c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #476
Description
Checklist
Check the boxes that apply (put an
xin the brackets, like[x]). You can also check boxes after the PR is created.❤️ Thank you for your contribution!