fix(bindings): exclude preserve_none instruction from bindings
#620
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20397299813Details
💛 - Coveralls |
ptondereau
force-pushed
the
fix/clang-arm64-preserve-none
branch
8 times, most recently
from
5057152 to
fa17044
Compare
ptondereau
force-pushed
the
fix/clang-arm64-preserve-none
branch
from
fa17044 to
25c6a0f
Compare
Member
Author
|
@Xenira if you have a better move... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bindgendoesn't support calling thepreserve_noneconvention that has been introduced in the last PHP 8.5.1.We can't exclude it with Clang Builder nor passing CFLAGS because this convention is used everywhere in the PHP src code.
I've forked bindgen + clang-sys to be able to build an extension on arm64 with macOS, but we clearly need an update from these repositories.
PHP issue: php/php-src#20546