Merged
Conversation
ptondereau
force-pushed
the
fix/cloning-class
branch
2 times, most recently
from
d9ce811 to
bb55264
Compare
ptondereau
force-pushed
the
fix/cloning-class
branch
from
bb55264 to
30e1ed6
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #683
Note: our
object_properties_initinitializes the properties table with default values, thenzend_objects_clone_membersdtors those defaults and copies from the original. PHP's default setsZVAL_UNDEFfirst instead. Both work, but ours does a small unnecessary alloc+free cycle for each default property.In the end, this matches the PHP cloning contract: properties are shallow-copied,
__clone()is invoked. The Rust data is cloned via Clone::clone(), which is the correct equivalent since the Rust struct owns its data independently.