fix: address clippy 1.95.0 lint errors#728
Merged
ptondereau merged 2 commits intoextphprs:masterfrom Apr 20, 2026
Merged
Conversation
- drop trailing comma in `panic!` (unnecessary_trailing_comma) - remove redundant `as u32` casts on already-`u32` expressions in `exception_observer` (unnecessary_cast) - collapse nested `if` into match arm guard in cargo-php installer (collapsible_match)
Aligns the devshell toolchain with CI stable (1.95.0) so local `cargo clippy` surfaces the same lints the workflow enforces. - nixpkgs: 46db2e09 -> 4bd9165a - rust-overlay: 75900435 -> 25d75be8
Coverage Report for CI Build 24656691002Coverage increased (+0.005%) to 65.9%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Bencher Report| Branch | fix/clippy-1-95-0 |
| Testbed | PHP 8.4.20 (cli) (built: Apr 11 2026 00:52:25) (NTS) |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes clippy 1.95.0 lint errors
Checklist