fix(ui): restore column drag-to-reorder functionality#19
Merged
Conversation
Column reordering was broken because both columns and cards used plain UUID strings as the drag transferable type. When dragging a column over another column, the inner ColumnView's dropDestination for cards would accept the drop (since it accepts any valid UUID) before the outer column reorder handler could process it. Fix: - Prefix column drag data with "column:" to differentiate from card drags - Move column drop handling into ColumnView via callback (onDropColumnId) - ColumnView's dropDestination now checks for "column:" prefix and routes to the appropriate handler Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dropDestinationhandlersString.selfbut are differentiated by acolumn:prefixonDropColumnIdcallback to ColumnView to handle column reordering within the same drop handlerProblem
When dragging a column over another column, the inner ColumnView's
dropDestination(for cards) was consuming the drop event before the outer column reorder handler could process it. Even though the card handler returnedfalsefor invalid UUIDs, SwiftUI doesn't bubble drops up to parent views.Solution
column:to differentiate from card dragsonDropColumnIdcallbackdropDestinationnow checks for thecolumn:prefix and routes to the appropriate handlerTest plan
🤖 Generated with Claude Code